Skip to content

Conversation

@theobarberbany
Copy link
Contributor

This change builds the GCR and ACR credential providers in CI.

This is due to bug OCPBUGS-30970. Initially, we did not think we needed builds in 4.15, but due to RHEL workers not always being upgraded before the cluster, we do (see bug).

This builds the RPMs in CI to ensure no 4.15 backports break the RPM builds.

@theobarberbany theobarberbany changed the title Builds ACR, GCR credential providers in CI OCPBUGS-30970: Builds ACR, GCR credential providers in CI Apr 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2024
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-30970, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This change builds the GCR and ACR credential providers in CI.

This is due to bug OCPBUGS-30970. Initially, we did not think we needed builds in 4.15, but due to RHEL workers not always being upgraded before the cluster, we do (see bug).

This builds the RPMs in CI to ensure no 4.15 backports break the RPM builds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from damdo and elmiko April 22, 2024 10:37
@openshift-ci-robot
Copy link
Contributor

@theobarberbany, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 72: did not find expected key)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@theobarberbany theobarberbany force-pushed the acr-gcr-credential-provider-4.15 branch 2 times, most recently from 5a6ea77 to 73e5baa Compare April 22, 2024 12:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@theobarberbany: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build09-dry
  • /test build10-dry
  • /test check-gh-automation
  • /test check-gh-automation-tide
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hosted-mgmt-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test stackrox-stackrox-stackrox-stackrox-check
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test pull-ci-openshift-cloud-provider-azure-release-4.15-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@theobarberbany: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build09-dry
  • /test build10-dry
  • /test check-gh-automation
  • /test check-gh-automation-tide
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hosted-mgmt-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test stackrox-stackrox-stackrox-stackrox-check
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test pull-ci-openshift-cloud-provider-gcp-release-4.15-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@theobarberbany, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build02: failed waiting for imagestreamtag ocp/builder:rhel-9-golang-1.21-openshift-4.15 to appear: get failed: client rate limiter Wait returned an error: context deadline exceeded

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@theobarberbany, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build02: failed waiting for imagestreamtag ocp/builder:rhel-9-golang-1.21-openshift-4.15 to appear: get failed: client rate limiter Wait returned an error: context deadline exceeded

If the problem persists, please contact Test Platform.

@theobarberbany theobarberbany force-pushed the acr-gcr-credential-provider-4.15 branch from 73e5baa to adbb9f6 Compare April 22, 2024 12:26
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

This change builds the GCR and ACR credential providers in CI.

This is due to bug OCPBUGS-30970. Initially, we did not think we needed
builds in 4.15, but due to RHEL workers not always being upgraded before
the cluster, we do (see bug).

This builds the RPMs in CI to ensure no 4.15 backports break the RPM
builds.
@theobarberbany theobarberbany force-pushed the acr-gcr-credential-provider-4.15 branch from adbb9f6 to 2777077 Compare April 23, 2024 08:57
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@theobarberbany: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-gcp-release-4.15-images openshift/cloud-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cloud-provider-gcp-release-4.15-e2e-gcp-ovn openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.15-e2e-gcp-ovn-upgrade openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.15-fmt openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.15-verify-commits openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-images openshift/cloud-provider-azure presubmit Presubmit changed
pull-ci-openshift-cloud-provider-azure-release-4.15-e2e-azure-ovn openshift/cloud-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-e2e-azure-ovn-upgrade openshift/cloud-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-unit openshift/cloud-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-verify openshift/cloud-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-verify-commits openshift/cloud-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-azure-release-4.15-verify-git-history openshift/cloud-provider-azure presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-provider-azure/release-4.15/unit 73e5baa link unknown /pj-rehearse pull-ci-openshift-cloud-provider-azure-release-4.15-unit
ci/rehearse/openshift/cloud-provider-azure/release-4.15/e2e-azure-ovn-upgrade 73e5baa link unknown /pj-rehearse pull-ci-openshift-cloud-provider-azure-release-4.15-e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cloud-provider-azure-release-4.15-e2e-azure-ovn

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@theobarberbany you'll need to rehearsal ack to get this merged.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@theobarberbany: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 28, 2024
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-30970, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.15.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-30970, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 28, 2024
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-30970, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 28, 2024
@openshift-ci openshift-ci bot requested a review from sunzhaohua2 May 28, 2024 08:33
@openshift-merge-bot openshift-merge-bot bot merged commit da47c68 into openshift:master May 28, 2024
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: Jira Issue OCPBUGS-30970: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30970 has been moved to the MODIFIED state.

Details

In response to this:

This change builds the GCR and ACR credential providers in CI.

This is due to bug OCPBUGS-30970. Initially, we did not think we needed builds in 4.15, but due to RHEL workers not always being upgraded before the cluster, we do (see bug).

This builds the RPMs in CI to ensure no 4.15 backports break the RPM builds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants